Skip to content

Fix for issue #2589 - i2Csetup for ESP 32-C3 #2600

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2025
Merged

Fix for issue #2589 - i2Csetup for ESP 32-C3 #2600

merged 5 commits into from
Jan 20, 2025

Conversation

SimonGAndrews
Copy link
Contributor

See comments in the issue #2589 regarding the details of the change and the testing completed.
Note

  • the ESP32-S3 build was not tested but hopefully and should be ok.
  • the element of this change, which reverses default pins for SDA & SCL for the ESP32 build (as discussed in the issue) will be a breaking change for anyone depending upon the I2C1.setup() function without specifying SDA and SCL in a config for the an ESP32 setup. However the ESP32 build will now be inline with common documentation.

@gfwilliams
Copy link
Member

This looks excellent - thank you! I think it's very unlikely folks will be using I2C.setup without specifying pins so I'm pretty sure we're good.

@gfwilliams gfwilliams merged commit f7442b4 into espruino:master Jan 20, 2025
21 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonGAndrews @gfwilliams